git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Fixes to mh/rebase-fixup

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jan 22, 2010, 09:22 UTC
Message-ID
<cover.1264151435.git.mhagger@alum.mit.edu>

This patch series contains fixes to the mh/rebase-fixup patch series as suggested by reviewers on the mailing list.

Since the mh/rebase-fixup patch series is already in "next", I have written these fixup patches against "next". I hope that is OK.

The third patch removes the attempt to use one-shot export of variables in do_with_author(), as the "$@" command that it calls might be a shell function. This issue was discussed on the mailing list [1]. This change has the side effect that the GIT_AUTHOR_* variables remain exported after do_with_author() returns, but I don't think that this is a problem in the context of git-rebase--interactive.sh. However, additional review would be welcome here.

[1] http://marc.info/?l=git&m=126345851831751&w=2
Michael Haggerty (3):
  rebase -i: Avoid non-portable "test X -a Y"
  rebase -i: Enclose sed command substitution in quotes
  rebase -i: Export GIT_AUTHOR_* variables explicitly
 git-rebase--interactive.sh |    6 ++----
 t/lib-rebase.sh            |    2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)
Next: Michael Haggerty
Message 1 of 7 in “Fixes to mh/rebase-fixup”
  1. 0/3 Fixes to mh/rebase-fixupMichael Haggerty, Jan 22, 2010
  2. 1/3 rebase -i: Avoid non-portable "test X -a Y"Michael Haggerty, Jan 22, 2010
  3. 2/3 rebase -i: Enclose sed command substitution in quotesMichael Haggerty, Jan 22, 2010
  4. 3/3 rebase -i: Export GIT_AUTHOR_* variables explicitlyMichael Haggerty, Jan 22, 2010
  5. Johannes SchindelinJan 22, 2010
  6. Junio C HamanoJan 22, 2010
  7. Michael HaggertyJan 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.