git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] rebase -i: Export GIT_AUTHOR_* variables explicitly

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 22, 2010, 11:16 UTC
Message-ID
<alpine.DEB.1.00.1001221212350.4985@pacific.mpi-cbg.de>
In-Reply-To
<c6efda03848abc00cf8bf8d84fc34ef0d652b64c.1264151435.git.mhagger@alum.mit.edu>
Hi,
On Fri, 22 Jan 2010, Michael Haggerty wrote:
> As pointed out on the mailing list, one-shot shell variable exports do
> not necessarily work with shell functions.  So export the GIT_AUTHOR_*
> variables explicitly using "export".

This one's a bit hairy; I really was not sure about unintended side effects, that is why I avoided the export.

Just imagine, for example, some git commit --amend which forgets to set the author information; I am not saying that this is happening, but I cannot be sure, because every possible code path to a git commit/commit-tree has to be checked, and this does not mean that future patches will not introduce such broken code, either.

It might also be possible that some people scripted rebase -i with a custom "editor" as in the tests (I have done so in the past). They would be affected.

Ciao, Dscho

Previous: Michael HaggertyNext: Junio C Hamano
Message 5 of 7 in “Fixes to mh/rebase-fixup”
  1. 0/3 Fixes to mh/rebase-fixupMichael Haggerty, Jan 22, 2010
  2. 1/3 rebase -i: Avoid non-portable "test X -a Y"Michael Haggerty, Jan 22, 2010
  3. 2/3 rebase -i: Enclose sed command substitution in quotesMichael Haggerty, Jan 22, 2010
  4. 3/3 rebase -i: Export GIT_AUTHOR_* variables explicitlyMichael Haggerty, Jan 22, 2010
  5. Johannes SchindelinJan 22, 2010
  6. Junio C HamanoJan 22, 2010
  7. Michael HaggertyJan 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.