git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] submodule path handling fixes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 7, 2009, 13:42 UTC
Message-ID
<cover.1234013924u.git.johannes.schindelin@gmx.de>
In-Reply-To
<7vfxiqy76k.fsf@gitster.siamese.dyndns.org>

My earlier attempt at this was misguided by my laziness, and I was willing to sacrifice correctness for the ability to move on to other problems.

So now, I taught plumbing to handle the trailing slash problem, which is not only much cleaner, but helps other users of ls-files, too.

Note that at this moment, it is beyond my reach to fix the issue that "git submodule no-such-submodule" will _only_ warn and not _fail_.

That would take a builtinification, as ls-files is used in a pipe in git-submodule.sh, and AFAIR there is no really portable way to catch errors in a pipe, short of using temporary files.

Johannes Schindelin (2):
  Let ls-files strip trailing slashes in submodules' paths
  submodule: warn about non-submodules
 builtin-ls-files.c         |   21 ++++++++++++++++++++-
 git-submodule.sh           |    2 +-
 t/t7400-submodule-basic.sh |   13 +++++++++++++
 3 files changed, 34 insertions(+), 2 deletions(-)
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 8 in “submodule: handle trailing slash, warn about non-submodules”
  1. submodule: handle trailing slash, warn about non-submodulesJohannes Schindelin, Feb 6, 2009
  2. Junio C HamanoFeb 6, 2009
  3. Johannes SchindelinFeb 6, 2009
  4. Junio C HamanoFeb 7, 2009
  5. 0/2 submodule path handling fixesJohannes Schindelin, Feb 7, 2009
  6. Junio C HamanoFeb 7, 2009
  7. 1/2 Let ls-files strip trailing slashes in submodules' pathsJohannes Schindelin, Feb 7, 2009
  8. 2/2 submodule: warn about non-submodulesJohannes Schindelin, Feb 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.