[PATCH 0/2] submodule path handling fixes
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 7, 2009, 13:42 UTC
- Message-ID
- <cover.1234013924u.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <7vfxiqy76k.fsf@gitster.siamese.dyndns.org>
My earlier attempt at this was misguided by my laziness, and I was willing to sacrifice correctness for the ability to move on to other problems.
So now, I taught plumbing to handle the trailing slash problem, which is not only much cleaner, but helps other users of ls-files, too.
Note that at this moment, it is beyond my reach to fix the issue that "git submodule no-such-submodule" will _only_ warn and not _fail_.
That would take a builtinification, as ls-files is used in a pipe in git-submodule.sh, and AFAIR there is no really portable way to catch errors in a pipe, short of using temporary files.
Johannes Schindelin (2): Let ls-files strip trailing slashes in submodules' paths submodule: warn about non-submodules
builtin-ls-files.c | 21 ++++++++++++++++++++- git-submodule.sh | 2 +- t/t7400-submodule-basic.sh | 13 +++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-)