Re: [PATCH] submodule: handle trailing slash, warn about non-submodules

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 6, 2009, 11:41 UTC
Message-ID: <alpine.DEB.1.00.0902061238060.7377@intel-tinevez-2-302>
In-Reply-To: <7vzlh0875l.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 5 Feb 2009, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Earlier, when you called
> >
> > 	git submodule path/to/submodule/
> >
> > (which happens easily if you are a heavy user of tab-completion), Git
> > would silently ignore the given path, as "git ls-files path/to/submodule/"
> > does not return anything due to the trailing slash.
> 
> Does --error-unmatch help in such a case to avoid shell loops?

No, as the second issue solved by the shell loop still holds true:

	$ git ls-files --error-unmatch submodule/
	error: pathspec 'submodule/' did not match any file(s) known to git.
	Did you forget to 'git add'?

That would be really awkward, don't you think?

BTW I have been asked about this behavior _easily_ a 50 times. I just finally broke down and went for the easiest solution.

A proper solution would most probably involve a rewrite as a builtin.

Ciao, Dscho