git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 00/23] Makefile: dependency fixes, make noop runtime ~1.4x faster

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Nov 16, 2021, 12:00 UTC
Message-ID
<cover-v3-00.23-00000000000-20211116T114334Z-avarab@gmail.com>
In-Reply-To
<cover-v2-00.18-00000000000-20211112T214150Z-avarab@gmail.com>

As noted in v2[1] this series fixes various dependency issues in the Makfile.

New in v3 is a fix for the dependency issue Mike Hommey reported[2] with hook-list.h, and 3x new and big optimizations that I'd planned to submit later on-top, but I figured would be better to consider as part of these general dependency improvements.

With those new changes on top we run ~1.4x faster on no-op runs (under
NO_TCLTK=Y, since that would otherwise eat most of our runtime either
way):
    
    $ git hyperfine -L rev origin/next,HEAD~0 -s 'make -j8 all NO_TCLTK=Y' 'make NO_TCLTK=Y' --warmup 10 -r 10
    Benchmark 1: make NO_TCLTK=Y' in 'origin/next
      Time (mean ± σ):     187.4 ms ±   2.4 ms    [User: 146.5 ms, System: 57.1 ms]
      Range (min … max):   184.7 ms … 192.8 ms    10 runs
     
    Benchmark 2: make NO_TCLTK=Y' in 'HEAD~0
      Time (mean ± σ):     136.1 ms ±   0.9 ms    [User: 103.0 ms, System: 47.6 ms]
      Range (min … max):   135.4 ms … 138.2 ms    10 runs
     
    Summary
      'make NO_TCLTK=Y' in 'HEAD~0' ran
        1.38 ± 0.02 times faster than 'make NO_TCLTK=Y' in 'origin/next'

Which, as noted before is working nicely towards making executing "make" in a loop faster, such as under "git rebase --exec".

Those optimizations are a mixture of clever and "dumb but works". E.g. around 10% of the runtime was spent by the Makefile looking for git's sources in the RCS and SCCS source control management systems, before giving up and considering the relevant file on disk.

1. https://lore.kernel.org/git/cover-v2-00.18-00000000000-20211112T214150Z-avarab@gmail.com
2. https://lore.kernel.org/git/20211115230032.3or3qqlsdnxjtrol@glandium.org/
Ævar Arnfjörð Bjarmason (23):
  Makefile: don't invoke msgfmt with --statistics
  Makefile: don't set up "perl/build" rules under NO_PERL=Y
  Makefile: use "=" not ":=" for po/* and perl/*
  Makefile: clean perl/build/ even with NO_PERL=Y
  Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERROR
  Makefile: guard Perl-only variable assignments
  Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"
  Makefile: adjust Perl-related comments & whitespace
  Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graph
  Makefile: create a GIT-PYTHON-DEFINES, like "PERL"
  Makefile: stop needing @@GIT_VERSION@@ in *.perl scripts
  Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to it
  Makefile: move $(comma), $(empty) and $(space) to shared.mak
  Makefile: re-add and use the "shellquote" macros
  Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}
  Makefile: add "$(QUIET)" boilerplate to shared.mak
  Makefile: use $(wspfx) for $(QUIET...) in shared.mak
  Makefiles: add and use wildcard "mkdir -p" template
  Makefile: correct the dependency graph of hook-list.h
  Makefile: use $(file) I/O instead of "FORCE" when possible
  Makefile: disable GNU make built-in wildcard rules
  Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)
  Makefile: move ".SUFFIXES" rule to shared.mak
 .gitignore             |   2 +-
 Documentation/Makefile |  71 +---------
 Makefile               | 313 +++++++++++++++--------------------------
 config.mak.uname       |   1 -
 git-cvsserver.perl     |   6 +-
 git-send-email.perl    |   7 +-
 git-svn.perl           |   2 +-
 shared.mak             | 187 ++++++++++++++++++++++++
 t/Makefile             |  34 ++---
 templates/Makefile     |  19 +--
 10 files changed, 337 insertions(+), 305 deletions(-)
 create mode 100644 shared.mak
Range-diff against v2:
 1:  75ebf7b04e5 =  1:  1621ca72c1d Makefile: don't invoke msgfmt with --statistics
 2:  138f60ba37b =  2:  b7c36c9fea0 Makefile: don't set up "perl/build" rules under NO_PERL=Y
 3:  472e1eb74bd =  3:  510499d18ba Makefile: use "=" not ":=" for po/* and perl/*
 4:  a5ce2dce164 =  4:  37f3591bcca Makefile: clean perl/build/ even with NO_PERL=Y
 5:  04dbc1d2809 =  5:  e38c90ad0b6 Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERROR
 6:  eea89794493 =  6:  98e14c7eba9 Makefile: guard Perl-only variable assignments
 7:  e06732d4639 =  7:  047a42b01cf Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"
 8:  a9502a23989 =  8:  0c0a3de390e Makefile: adjust Perl-related comments & whitespace
 9:  c1336fc0a56 =  9:  1ece3160915 Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graph
10:  41f65a12205 = 10:  e9b61cd0ba5 Makefile: create a GIT-PYTHON-DEFINES, like "PERL"
11:  bfa15059d60 = 11:  b020f8e3257 Makefile: stop needing @@GIT_VERSION@@ in *.perl scripts
12:  656d02ab641 = 12:  19539ce7d2d Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to it
13:  6e25ac71cbc = 13:  6c9291c2c9f Makefile: move $(comma), $(empty) and $(space) to shared.mak
14:  64296e6e8e5 = 14:  e811a907b08 Makefile: re-add and use the "shellquote" macros
15:  5654d7f7f29 = 15:  fac30fe8b56 Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}
16:  0a348b54491 = 16:  a3e3acea82d Makefile: add "$(QUIET)" boilerplate to shared.mak
17:  34f692144d1 = 17:  22264f431c8 Makefile: use $(wspfx) for $(QUIET...) in shared.mak
18:  5b3986bc4a8 = 18:  d61e2b44f68 Makefiles: add and use wildcard "mkdir -p" template
 -:  ----------- > 19:  234b4eb613c Makefile: correct the dependency graph of hook-list.h
 -:  ----------- > 20:  567ad5c3ebc Makefile: use $(file) I/O instead of "FORCE" when possible
 -:  ----------- > 21:  cb3ae5ce00b Makefile: disable GNU make built-in wildcard rules
 -:  ----------- > 22:  88cfc946b37 Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)
 -:  ----------- > 23:  276e226f0a8 Makefile: move ".SUFFIXES" rule to shared.mak
-- 
2.34.0.795.g1e9501ab396
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 41 of 107 in “Makefiles: dependency correctness & speedup”
  1. 00/16 Makefiles: dependency correctness & speedupÆvar Arnfjörð Bjarmason, Nov 6, 2021
  2. 02/16 Makefile: clean perl/build/ even with NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 6, 2021
  3. Junio C HamanoNov 9, 2021
  4. 01/16 Makefile: don't set up "perl/build" rules under NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 6, 2021
  5. 03/16 Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERRORÆvar Arnfjörð Bjarmason, Nov 6, 2021
  6. 04/16 Makefile: move Perl-only variable assignments under !NO_PERLÆvar Arnfjörð Bjarmason, Nov 6, 2021
  7. Junio C HamanoNov 9, 2021
  8. 05/16 Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graphÆvar Arnfjörð Bjarmason, Nov 6, 2021
  9. Eric SunshineNov 7, 2021
  10. 06/16 Makefile: don't have Perl over-depend on GIT-BUILD-OPTIONSÆvar Arnfjörð Bjarmason, Nov 6, 2021
  11. 07/16 Makefile: create a GIT-PYTHON-DEFINES, like "PERL"Ævar Arnfjörð Bjarmason, Nov 6, 2021
  12. Eric SunshineNov 7, 2021
  13. 08/16 Makefile: stop needing @@GIT_VERSION@@ in *.perl scriptsÆvar Arnfjörð Bjarmason, Nov 6, 2021
  14. 09/16 Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to itÆvar Arnfjörð Bjarmason, Nov 6, 2021
  15. 10/16 Makefile: move $(comma), $(empty) and $(space) to shared.makÆvar Arnfjörð Bjarmason, Nov 6, 2021
  16. 11/16 Makefile: re-add and use the "shellquote" macrosÆvar Arnfjörð Bjarmason, Nov 6, 2021
  17. 12/16 Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}Ævar Arnfjörð Bjarmason, Nov 6, 2021
  18. 13/16 Makefile: add "$(QUIET)" boilerplate to shared.makÆvar Arnfjörð Bjarmason, Nov 6, 2021
  19. 14/16 Makefile: use $(wspfx) for $(QUIET...) in shared.makÆvar Arnfjörð Bjarmason, Nov 6, 2021
  20. 15/16 Makefiles: add and use wildcard "mkdir -p" templateÆvar Arnfjörð Bjarmason, Nov 6, 2021
  21. 16/16 Makefile: don't invoke msgfmt with --statisticsÆvar Arnfjörð Bjarmason, Nov 6, 2021
  22. 00/18 Makefiles: dependency correctness & speedupÆvar Arnfjörð Bjarmason, Nov 12, 2021
  23. 01/18 Makefile: don't invoke msgfmt with --statisticsÆvar Arnfjörð Bjarmason, Nov 12, 2021
  24. 02/18 Makefile: don't set up "perl/build" rules under NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 12, 2021
  25. 03/18 Makefile: use "=" not ":=" for po/* and perl/*Ævar Arnfjörð Bjarmason, Nov 12, 2021
  26. 04/18 Makefile: clean perl/build/ even with NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 12, 2021
  27. 05/18 Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERRORÆvar Arnfjörð Bjarmason, Nov 12, 2021
  28. 07/18 Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"Ævar Arnfjörð Bjarmason, Nov 12, 2021
  29. 09/18 Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graphÆvar Arnfjörð Bjarmason, Nov 12, 2021
  30. 06/18 Makefile: guard Perl-only variable assignmentsÆvar Arnfjörð Bjarmason, Nov 12, 2021
  31. 08/18 Makefile: adjust Perl-related comments & whitespaceÆvar Arnfjörð Bjarmason, Nov 12, 2021
  32. 10/18 Makefile: create a GIT-PYTHON-DEFINES, like "PERL"Ævar Arnfjörð Bjarmason, Nov 12, 2021
  33. 12/18 Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to itÆvar Arnfjörð Bjarmason, Nov 12, 2021
  34. 13/18 Makefile: move $(comma), $(empty) and $(space) to shared.makÆvar Arnfjörð Bjarmason, Nov 12, 2021
  35. 14/18 Makefile: re-add and use the "shellquote" macrosÆvar Arnfjörð Bjarmason, Nov 12, 2021
  36. 11/18 Makefile: stop needing @@GIT_VERSION@@ in *.perl scriptsÆvar Arnfjörð Bjarmason, Nov 12, 2021
  37. 16/18 Makefile: add "$(QUIET)" boilerplate to shared.makÆvar Arnfjörð Bjarmason, Nov 12, 2021
  38. 15/18 Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}Ævar Arnfjörð Bjarmason, Nov 12, 2021
  39. 17/18 Makefile: use $(wspfx) for $(QUIET...) in shared.makÆvar Arnfjörð Bjarmason, Nov 12, 2021
  40. 18/18 Makefiles: add and use wildcard "mkdir -p" templateÆvar Arnfjörð Bjarmason, Nov 12, 2021
  41. 00/23 Makefile: dependency fixes, make noop runtime ~1.4x fasterÆvar Arnfjörð Bjarmason, Nov 16, 2021
  42. 02/23 Makefile: don't set up "perl/build" rules under NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 16, 2021
  43. 01/23 Makefile: don't invoke msgfmt with --statisticsÆvar Arnfjörð Bjarmason, Nov 16, 2021
  44. 03/23 Makefile: use "=" not ":=" for po/* and perl/*Ævar Arnfjörð Bjarmason, Nov 16, 2021
  45. Mike HommeyNov 17, 2021
  46. 04/23 Makefile: clean perl/build/ even with NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 16, 2021
  47. 06/23 Makefile: guard Perl-only variable assignmentsÆvar Arnfjörð Bjarmason, Nov 16, 2021
  48. 05/23 Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERRORÆvar Arnfjörð Bjarmason, Nov 16, 2021
  49. Mike HommeyNov 17, 2021
  50. Ævar Arnfjörð BjarmasonNov 17, 2021
  51. 10/23 Makefile: create a GIT-PYTHON-DEFINES, like "PERL"Ævar Arnfjörð Bjarmason, Nov 16, 2021
  52. 12/23 Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to itÆvar Arnfjörð Bjarmason, Nov 16, 2021
  53. 11/23 Makefile: stop needing @@GIT_VERSION@@ in *.perl scriptsÆvar Arnfjörð Bjarmason, Nov 16, 2021
  54. 09/23 Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graphÆvar Arnfjörð Bjarmason, Nov 16, 2021
  55. 08/23 Makefile: adjust Perl-related comments & whitespaceÆvar Arnfjörð Bjarmason, Nov 16, 2021
  56. 07/23 Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"Ævar Arnfjörð Bjarmason, Nov 16, 2021
  57. 13/23 Makefile: move $(comma), $(empty) and $(space) to shared.makÆvar Arnfjörð Bjarmason, Nov 16, 2021
  58. 14/23 Makefile: re-add and use the "shellquote" macrosÆvar Arnfjörð Bjarmason, Nov 16, 2021
  59. 16/23 Makefile: add "$(QUIET)" boilerplate to shared.makÆvar Arnfjörð Bjarmason, Nov 16, 2021
  60. 15/23 Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}Ævar Arnfjörð Bjarmason, Nov 16, 2021
  61. Mike HommeyNov 17, 2021
  62. Ævar Arnfjörð BjarmasonNov 17, 2021
  63. 17/23 Makefile: use $(wspfx) for $(QUIET...) in shared.makÆvar Arnfjörð Bjarmason, Nov 16, 2021
  64. 18/23 Makefiles: add and use wildcard "mkdir -p" templateÆvar Arnfjörð Bjarmason, Nov 16, 2021
  65. Mike HommeyNov 17, 2021
  66. Ævar Arnfjörð BjarmasonNov 17, 2021
  67. Mike HommeyNov 17, 2021
  68. Ævar Arnfjörð BjarmasonNov 17, 2021
  69. Mike HommeyNov 18, 2021
  70. Ævar Arnfjörð BjarmasonNov 18, 2021
  71. 21/23 Makefile: disable GNU make built-in wildcard rulesÆvar Arnfjörð Bjarmason, Nov 16, 2021
  72. Mike HommeyNov 17, 2021
  73. Ævar Arnfjörð BjarmasonNov 17, 2021
  74. 22/23 Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)Ævar Arnfjörð Bjarmason, Nov 16, 2021
  75. 23/23 Makefile: move ".SUFFIXES" rule to shared.makÆvar Arnfjörð Bjarmason, Nov 16, 2021
  76. 20/23 Makefile: use $(file) I/O instead of "FORCE" when possibleÆvar Arnfjörð Bjarmason, Nov 16, 2021
  77. 19/23 Makefile: correct the dependency graph of hook-list.hÆvar Arnfjörð Bjarmason, Nov 16, 2021
  78. Mike HommeyNov 17, 2021
  79. 00/23 Makefile: dependency fixes, make noop runtime ~1.4x fasterÆvar Arnfjörð Bjarmason, Nov 17, 2021
  80. 01/23 Makefile: don't invoke msgfmt with --statisticsÆvar Arnfjörð Bjarmason, Nov 17, 2021
  81. 02/23 Makefile: don't set up "perl/build" rules under NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 17, 2021
  82. 03/23 Makefile: use "=" not ":=" for po/* and perl/*Ævar Arnfjörð Bjarmason, Nov 17, 2021
  83. 04/23 Makefile: clean perl/build/ even with NO_PERL=YÆvar Arnfjörð Bjarmason, Nov 17, 2021
  84. 05/23 Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERRORÆvar Arnfjörð Bjarmason, Nov 17, 2021
  85. 07/23 Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"Ævar Arnfjörð Bjarmason, Nov 17, 2021
  86. 06/23 Makefile: guard Perl-only variable assignmentsÆvar Arnfjörð Bjarmason, Nov 17, 2021
  87. 08/23 Makefile: adjust Perl-related comments & whitespaceÆvar Arnfjörð Bjarmason, Nov 17, 2021
  88. 09/23 Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graphÆvar Arnfjörð Bjarmason, Nov 17, 2021
  89. 10/23 Makefile: create a GIT-PYTHON-DEFINES, like "PERL"Ævar Arnfjörð Bjarmason, Nov 17, 2021
  90. 11/23 Makefile: stop needing @@GIT_VERSION@@ in *.perl scriptsÆvar Arnfjörð Bjarmason, Nov 17, 2021
  91. 12/23 Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to itÆvar Arnfjörð Bjarmason, Nov 17, 2021
  92. 13/23 Makefile: move $(comma), $(empty) and $(space) to shared.makÆvar Arnfjörð Bjarmason, Nov 17, 2021
  93. 14/23 Makefile: re-add and use the "shellquote" macrosÆvar Arnfjörð Bjarmason, Nov 17, 2021
  94. Junio C HamanoDec 13, 2021
  95. Junio C HamanoDec 14, 2021
  96. 15/23 Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}Ævar Arnfjörð Bjarmason, Nov 17, 2021
  97. Junio C HamanoNov 19, 2021
  98. Junio C HamanoNov 19, 2021
  99. Ævar Arnfjörð BjarmasonNov 19, 2021
  100. 16/23 Makefile: add "$(QUIET)" boilerplate to shared.makÆvar Arnfjörð Bjarmason, Nov 17, 2021
  101. 17/23 Makefile: use $(wspfx) for $(QUIET...) in shared.makÆvar Arnfjörð Bjarmason, Nov 17, 2021
  102. 18/23 Makefiles: add and use wildcard "mkdir -p" templateÆvar Arnfjörð Bjarmason, Nov 17, 2021
  103. 19/23 Makefile: correct the dependency graph of hook-list.hÆvar Arnfjörð Bjarmason, Nov 17, 2021
  104. 20/23 Makefile: use $(file) I/O instead of "FORCE" when possibleÆvar Arnfjörð Bjarmason, Nov 17, 2021
  105. 21/23 Makefile: disable GNU make built-in wildcard rulesÆvar Arnfjörð Bjarmason, Nov 17, 2021
  106. 22/23 Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)Ævar Arnfjörð Bjarmason, Nov 17, 2021
  107. 23/23 Makefile: move ".SUFFIXES" rule to shared.makÆvar Arnfjörð Bjarmason, Nov 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.