Re: [PATCH 07/16] Makefile: create a GIT-PYTHON-DEFINES, like "PERL"
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 7, 2021, 01:55 UTC
- Message-ID
- <CAPig+cScGUVDnApjQUz90Pm3_MTiUwD1HgX_DP2gc=TQ3ChkeQ@mail.gmail.com>
- In-Reply-To
- <patch-07.16-24c8f42aa7d-20211106T205717Z-avarab@gmail.com>
On Sat, Nov 6, 2021 at 5:03 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 20 quoted lines
> Create a new "GIT-PYTHON-DEFINES" file, and untangle the dependency > issues of the Python by copying over the patterns established for > building the adjacent Perl code in preceding commits. > > As with Perl, there's no real reason to depend on GIT-BUILD-OPTIONS or > GIT-CFLAGS when building the Python code, nor did we need > GIT-PREFIX. Let's instead add those variables we care about to a > "GIT-PYTHON-DEFINES". > [...] > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > diff --git a/Makefile b/Makefile > @@ -2369,18 +2369,14 @@ GIT-PERL-DEFINES: FORCE > +# Under NO_PERL=Y we'll still make GIT-PERL-DEFINES. We need to depend > +# on NO_PERL=Y itself for creating "unimplemented.sh" scripts. > +PYTHON_DEFINES = > +$(SCRIPT_PYTHON_GEN): GIT-PYTHON-DEFINES > +ifdef NO_PYTHON > +PYTHON_DEFINES += $(SHELL_PATH_SQ) > +PYTHON_DEFINES += $(NO_PYTHON)
The comment above this new Python-related goop is talking about PERL? Is that intentional?