git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrl

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 15, 2022, 10:44 UTC
Message-ID
<cover-0.2-00000000000-20220615T103852Z-avarab@gmail.com>

The $subject is a case where nothing is broken except potential user expectations, but as argued in 2/2 I think we really should rename this before we kick it out the door.

Having a "fetch" configuration configure "git push" is really confusing, and once we need to support it backing out of it would be a hassle.

Then 1/2 clarifies how it really works, and what it's aimed to do, and notes the major caveat that the check doesn't cover "pushurl" configuration, which in some setups is the only place you'll put passwords in URLs. I think it likewise makes sense to have that in v2.37.0 so we won't lull users into a false sense of security.

This is a relatively large change for an "rc", but the only code changes are s/fetch\.credentialsInUrl/transfer.credentialsInUrl/g, the rest is all docs.

There's a trivial conflict with my just-submitted https://lore.kernel.org/git/cover-0.1-00000000000-20220615T103609Z-avarab@gmail.com: The relevant "test_expect_success" line needs a "LIBCURL" prerequisite added in the merge conflict.

Ævar Arnfjörð Bjarmason (2):
  fetch doc: note "pushurl" caveat about "credentialsInUrl", elaborate
  transfer doc: move fetch.credentialsInUrl to "transfer" config
    namespace
 Documentation/RelNotes/2.37.0.txt |  6 +++--
 Documentation/config/fetch.txt    | 14 ------------
 Documentation/config/transfer.txt | 38 +++++++++++++++++++++++++++++++
 remote.c                          |  4 ++--
 t/t5516-fetch-push.sh             | 14 ++++++------
 t/t5601-clone.sh                  | 10 ++++----
 6 files changed, 56 insertions(+), 30 deletions(-)
-- 
2.36.1.1239.gfba91521d90
Next: Ævar Arnfjörð Bjarmason
Message 1 of 6 in “For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrl”
  1. 0/2 For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  2. 1/2 fetch doc: note "pushurl" caveat about "credentialsInUrl", elaborateÆvar Arnfjörð Bjarmason, Jun 15, 2022
  3. René ScharfeJun 26, 2022
  4. 2/2 transfer doc: move fetch.credentialsInUrl to "transfer" config namespaceÆvar Arnfjörð Bjarmason, Jun 15, 2022
  5. Derrick StoleeJun 15, 2022
  6. Junio C HamanoJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.