Re: [PATCH v2 1/2] branch: refactor "edit_description" code path
On 9/7/22 11:24 PM, Rubén Justo wrote:
Show 17 quoted lines
>
> On 9/7/22 10:25 PM, Junio C Hamano wrote:
>
> Maybe the return 1 when edit_branch_description(), was a typo I was maintaining?
>
>>> - }
>>> - strbuf_release(&branch_ref);
>>> + } else
>>> + ret = edit_branch_description(branch_name);
>>>
>>> - if (edit_branch_description(branch_name))
>>> - return 1;
>>> + strbuf_release(&branch_ref);
>>> + return ret;
>
> Thanks for you review.
>
Nevermind. 1 is the return for exit. Sorry.
I'm sending a v3 with your suggestions. Thanks again.
Rubén Justo <rjusto@gmail.com>