Re: [PATCH v4] branch: support for shortcuts like @{-1}, completed

From: Rubén Justo <rjusto@gmail.com>
Date: Oct 9, 2022, 22:27 UTC
Message-ID: <afec5288-7551-ff42-6dd8-899b5116394f@gmail.com>
In-Reply-To: <xmqq5ygs7pxg.fsf@gitster.g>

For me, the most value here is in the expressiveness, writing and reading a simple test.

    git config branch.desc-branch.description >actual &&
    test_cmp actual "Branch description\n\n"

vs

    git config branch.desc-branch.description >actual &&
    printf "Branch description\n\n" >expect &&
    test_cmp expect actual

vs

    printf "Branch description\n\n" >expect &&
...
    git config branch.desc-branch.description >actual &&
    test_cmp expect actual

vs (oops)

    printf "Branch description\n\n" >expect &&
...
    git config branch.desc-branch.description >actual &&
    printf "New branch description\n\n" >expect_ &&
    test_cmp expect actual

Less lines, less files and less error prone are a plus.

On 9/10/22 8:46, Eric Sunshine wrote:

> My knee-jerk reaction is that the form which takes a string as
> argument would hardly be used, thus an unnecessary complication. The

A quick overview over a not much elaborated search:

git grep -B 3 'test_cmp expect' | grep '\(echo\|cat\).*expect'

gives many results that imo should be beneficial of this expressiveness.

> form which accepts stdin could even be retrofitted onto the existing
> test_cmp, thus you don't even need to invent a new function name. A

Nice.  Maybe even the printf form with a "test ! -f", some risky though.

Show 5 quoted lines

> different approach would be to introduce a function `test_stdout`
> which both accepts a command to run, as well as the "expected" text on
> stdin with which to compare the output of the command; i.e. a
> combination of the existing `test_stdout_line_count` in
> t/test-lib-functions.sh and your proposed function above.

Sounds good to me but maybe this goes in the direction of "inducing bad usages", and the tests to cover starts to be not so simple...

On 9/10/22 21:33, Junio C Hamano wrote:

Show 10 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> 
>> That said, I'm not yet seeing all that much added value in such a
>> function; at most, it seems to save only a single line of code, and
>> it's not as if the code it's replacing was doing anything complicated
>> or hard to grok.
> 
> I share the sentiment.  Leaving the result that was used in comparison
> in file(s) also helps debugging.
>

And if this is fulfilled with a drop a file on failure? That resolves the '-' in the diff output result too.

Thank you.