Re: [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Mar 31, 2017, 13:20 UTC
- Message-ID
- <cf8baa5b-34ca-658e-0de5-03b69ab86521@jeffhostetler.com>
- In-Reply-To
- <xmqqa882336t.fsf@gitster.mtv.corp.google.com>
On 3/30/2017 4:44 PM, Junio C Hamano wrote:
Show 8 quoted lines
> Jeff King <peff@peff.net> writes: > >> Still, I'm not sure the extra layer of cache is all that valuable. It >> should be a single hash lookup in the config cache (in an operation that >> otherwise reads the entire index). > > OK, let's drop that part, then. >
Yes, let's omit the caching there. That way perf tests can run it multiple times with it on or off as they see fit. And in the normal case it will only be executed once anyway.