Re: [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread
- From
Jeff King <peff@peff.net>
- Date
- Mar 30, 2017, 20:39 UTC
- Message-ID
- <20170330203916.ckp62syupioo3hxc@sigill.intra.peff.net>
- In-Reply-To
- <20170330200648.GH27158@hank>
On Thu, Mar 30, 2017 at 09:06:48PM +0100, Thomas Gummerer wrote:
Show 9 quoted lines
> > Yeah, I think that would be fine. You _could_ write a t/perf test and > > then use your 400MB monstrosity as GIT_PERF_LARGE_REPO. But given that > > most people don't have such a thing, there's not much value over you > > just showing off the perf improvement in the commit message. > > Sorry if this was already discussed, but we already do have a perf > test for the index (p0002), and a corresponding helper program which > just does read_cache() and discard_cache(). Maybe we could re-use > that and add a second test running the same using the new config?
Oh, indeed. Yes, I would think the results of p0002 would probably show off Jeff's improvements.
-Peff