Re: Looking for help to understand external filter driver code

From: Torsten Bögershausen <tboegi@web.de>
Date: Jul 20, 2016, 02:33 UTC
Message-ID: <cdb8005a-2ed9-04da-fdbf-600accfac38f@web.de>
In-Reply-To: <BDD74384-AA02-4B60-A246-504B4C6DDF02@gmail.com>

On 07/20/2016 12:01 AM, Lars Schneider wrote:

Show 13 quoted lines

>
> On 19 Jul 2016, at 23:33, Junio C Hamano <gitster@pobox.com> wrote:
>
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>> Git writes --> 4 byte filename length
>>> Git writes --> filename string
>>
>> Why limit to 32GB?  Perhaps NUL termination is more appropriate
>> here?
> OK, I will use NUL termination for the filename.
> You're also right about the limit - I will use 8 byte to encode the
> content length.

Is there any reason to encode the file length in binary format? With all the discussions about big endianess, little endianess, 4GiB or 32 GiB. How about simply writing the length as ASCII ?

Unless we don't want to have a "spare" field for future extensions, it could be good to add an option field, which may be empty. On top of that, do we want a field separator different from the line separator ?

How about this: <options><TAB><length><TAB><filename><NUL>

<options> may be "var=value;var2=value2" or simply ""