Re: Looking for help to understand external filter driver code

From: Lars Schneider <larsxschneider@gmail.com>
Date: Jul 20, 2016, 09:43 UTC
Message-ID: <6CD48865-8D77-4582-AB41-FCD27D41017C@gmail.com>
In-Reply-To: <578F3D5E.2070201@gmail.com>

Show 13 quoted lines

> On 20 Jul 2016, at 10:59, Jakub Narębski <jnareb@gmail.com> wrote:
> 
> W dniu 2016-07-19 o 23:33, Junio C Hamano pisze:
>> Lars Schneider <larsxschneider@gmail.com> writes:
>> 
>>>> Git writes --> 4 byte filename length
>>>> Git writes --> filename string
>> 
>> Why limit to 32GB?  Perhaps NUL termination is more appropriate
>> here?
> 
> Errr, I think limiting _filename_ to 32GB is a reasonable
> assumption, for forever...

Well, Java packages can get reaaaally long :D

Show 8 quoted lines

> 
>>>> Git writes --> 4 byte content length
>>>> Git writes --> content string
> 
> ...while limiting file _content_ to 32GB might not be
> future-proof enough.
> 
> ;-)

I think this is what Junio meant to say. At least I interpreted it that way.

- Lars