git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: blameview and file contents

From
Aneesh Kumar <aneesh.kumar@gmail.com>
Date
Jan 30, 2007, 07:22 UTC
Message-ID
<cc723f590701292322q7365f99bg3b7c76834f6fbad8@mail.gmail.com>
In-Reply-To
<20070130065417.GA32640@spearce.org>
On 1/30/07, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 19 quoted lines
> Aneesh Kumar <aneesh.kumar@gmail.com> wrote:
> > I guess blame view need to pull the file content from the repository
> > rather than opening it directly. If i have a working copy that is not
> > yet committed it gives wrong results. I tried some changes as below.
> > But i guess there should be a much easier way.
>
> > -open(my $fh, '<', $fn)
> > -  or die "unable to open $fn: $!";
> > +$fh = get_file_handle("HEAD", $fn);
> >  while(<$fh>) {
> >    chomp;
> >    $fileview->{data}->[$.] = ['HEAD', '?', "$fn:$.", $_];
>
> Doesn't the following work just as well, and use a lot less code?
>
>   open(my $fh, '|-', 'git', 'cat-file', 'blob', "HEAD:$fn")
>
> ?
>

See i said that there should be a simple way. Can we get this documented in git-cat-file man page

-aneesh
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 5 in “blameview and file contents”
  1. Aneesh KumarJan 30, 2007
  2. Shawn O. PearceJan 30, 2007
  3. Aneesh KumarJan 30, 2007
  4. Shawn O. PearceJan 30, 2007
  5. Junio C HamanoJan 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.