Re: blameview and file contents

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 30, 2007, 06:54 UTC
Message-ID: <20070130065417.GA32640@spearce.org>
In-Reply-To: <cc723f590701292246v282408d0o27a0d8320c027743@mail.gmail.com>

Aneesh Kumar <aneesh.kumar@gmail.com> wrote:

> I guess blame view need to pull the file content from the repository
> rather than opening it directly. If i have a working copy that is not
> yet committed it gives wrong results. I tried some changes as below.
> But i guess there should be a much easier way.

Show 6 quoted lines

> -open(my $fh, '<', $fn)
> -  or die "unable to open $fn: $!";
> +$fh = get_file_handle("HEAD", $fn);
>  while(<$fh>) {
>    chomp;
>    $fileview->{data}->[$.] = ['HEAD', '?', "$fn:$.", $_];

Doesn't the following work just as well, and use a lot less code?

  open(my $fh, '|-', 'git', 'cat-file', 'blob', "HEAD:$fn")

-- 
Shawn.