Re: gitview 0.3

From: Aneesh Kumar <aneesh.kumar@gmail.com>
Date: Feb 2, 2006, 16:03 UTC
Message-ID: <cc723f590602020803u72bdff2ek95fba2ea30970170@mail.gmail.com>
In-Reply-To: <7vzmlauw35.fsf@assigned-by-dhcp.cox.net>

On 2/2/06, Junio C Hamano <junkio@cox.net> wrote:

Show 7 quoted lines

> Nice work for 0.low-number version.
>
> On my notebook, I felt really miserable to see that the middle
> band taking so much space to show rev committer timestamp and
> parents.  The bottom window starts with the same information
> repeated (worse, with unreadable timestamp format) and I had to
> scroll all the way down to view the rest of the commit message.

I have rearranged the default with respect these frames. Attaching the code below. Let me know if it is ok.

Show 10 quoted lines

>
> If you absolutely want the middle band, maybe instead of showing
> object names in "Parents" "Children" part, you can show the
> one-line commit logs from them there, and pop-up the object
> names along with the rest of commit log message as mouse hovers
> over.
>
> I missed "this commit is branch head of X" and "this commit is
> tagged with T" markers gitk has.
>

I am planning to add this. I am yet to learn fully how to use the cairo API. gitview was partly my attempt to learn pygtk.

> Needs a bit more compact layout to be useful for me.  In short,
> gitk's display does everything I want it to show in a compact
> enough way and I think there is no reason not to imitate it.
>

One thing i didn't like with gitk was the looks. And the diff window was so shaded i had to put real effort to read the contents. May be i didn't had necessary fonts. I don't know

> Do colors of nodes have any significance?  I couldn't tell from
> the UI (and I tried to figure it out without reading code --
> otherwise I cannot tell if the choice of colors is intuitive).
>

One parent of the child follows the same colour. It in a way let one figure out at what point branch happened and at what point they merged back.

> It might match more people's expectation if --with-diff were the
> default.
>

This is done. I am attaching the full code below. Can you get the gitview added git repository so that next time onwards i need to send only the diff.

Show 19 quoted lines

> This patch might make merges easier to read.
>
> -- >8 --
> [PATCH] Use "diff-tree -c" to display merges a bit more readably.
>
> --- a/gitview   2006-02-01 21:16:43.000000000 -0800
> +++ b/gitview   2006-02-01 21:46:24.000000000 -0800
> @@ -305,7 +305,7 @@
>                 return message
>
>         def diff_tree(self):
> -               fp = os.popen("git diff-tree --pretty -m -v -p " + " " + self.commit_sha1)
> +               fp = os.popen("git diff-tree --pretty -c -v -p " + " " + self.commit_sha1)
>                 diff = fp.read()
>                 fp.close()
>
>
>
>

I am using the --cc flag and if i don't have any message i get the commit message only using git cat-file. I guess that is ok

-aneesh