Re: gitview 0.3
- From
Junio C Hamano <junkio@cox.net>
- Date
- Feb 2, 2006, 06:13 UTC
- Message-ID
- <7vzmlauw35.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <cc723f590602012033w41b49b2ao4423707702086739@mail.gmail.com>
Nice work for 0.low-number version.
On my notebook, I felt really miserable to see that the middle band taking so much space to show rev committer timestamp and parents. The bottom window starts with the same information repeated (worse, with unreadable timestamp format) and I had to scroll all the way down to view the rest of the commit message.
If you absolutely want the middle band, maybe instead of showing object names in "Parents" "Children" part, you can show the one-line commit logs from them there, and pop-up the object names along with the rest of commit log message as mouse hovers over.
I missed "this commit is branch head of X" and "this commit is tagged with T" markers gitk has.
Needs a bit more compact layout to be useful for me. In short, gitk's display does everything I want it to show in a compact enough way and I think there is no reason not to imitate it.
Do colors of nodes have any significance? I couldn't tell from the UI (and I tried to figure it out without reading code -- otherwise I cannot tell if the choice of colors is intuitive).
It might match more people's expectation if --with-diff were the default.
This patch might make merges easier to read.
-- >8 -- [PATCH] Use "diff-tree -c" to display merges a bit more readably.
--- a/gitview 2006-02-01 21:16:43.000000000 -0800 +++ b/gitview 2006-02-01 21:46:24.000000000 -0800 @@ -305,7 +305,7 @@ return message def diff_tree(self): - fp = os.popen("git diff-tree --pretty -m -v -p " + " " + self.commit_sha1) + fp = os.popen("git diff-tree --pretty -c -v -p " + " " + self.commit_sha1) diff = fp.read() fp.close()