Re: Re: [BUG] git gui blame: Show History Context broken since 29e5573d

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 22, 2010, 23:29 UTC
Message-ID: <cb7bb73a1002221529r6aee3202l5b6609b59aea01fd@mail.gmail.com>
In-Reply-To: <20100222223802.GA9898@book.hvoigt.net>

On Mon, Feb 22, 2010 at 11:38 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:

Show 21 quoted lines

> On Mon, Feb 22, 2010 at 04:18:11PM +0100, Giuseppe Bilotta wrote:
>> On Mon, Feb 22, 2010 at 9:27 AM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> > Hi,
>> >
>> > In "git gui blame", right-clicking on the left fringe and chosing
>> > "Show History Context" in the context-menu doesn't work for me in the
>> > latest git. It says:
>> >
>> > couldn't change working directory to "": no such file or directory
>>
>> Definitely my fault. _gitworktree was not being set up correctly when
>> support for bare repositories was enabled and the repo was not bare
>> (like in the blame case). Patch incoming, can you see if it does the
>> job for you? It seems to fix it here.
>
> Isn't this the same bug as this one fixes:
>
> http://article.gmane.org/gmane.comp.version-control.git/140288
>
> cheers Heiko

Interesting, I missed that patch. However, I strongly suspect that patch is not correct, since in that case the setup of gitworktree is done before checking for bareness, meaning that when working in somerepo.git (bare repo) for which the config flag is not set, it might misdetect the situation as being in the non-bare case. I believe my fix to be more correct in this regard.

-- 
Giuseppe "Oblomov" Bilotta