Re: [PATCH] git-gui: fix worktree initialization with empty prefix

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 22, 2010, 15:39 UTC
Message-ID: <cb7bb73a1002220739j1eaae417je9358458f653ef7e@mail.gmail.com>
In-Reply-To: <vpqsk8t1e1g.fsf@bauges.imag.fr>

On Mon, Feb 22, 2010 at 4:32 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 10 quoted lines

> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> This is sort of a chicken-and-egg problem, because we should only
>> bother setting the worktree if we are not in a bare repository, but
>> an unset worktree is one of the conditions we check to see if we have
>> a bare repository.
>>
>> Maintain the same sequence of checks, but swap the check for bareness
>> support and bareness of repository, and check again for an unset
>> worktree if we are not in the bare case.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

>
> Tested-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>
> (don't forget Signed-off-by)

Damn. Thanks. I just set format.signoff so I won't forget again.

> Thanks,

Thank you for spotting and testing this.

-- 
Giuseppe "Oblomov" Bilotta