Re: [PATCH] gitweb: pull ref markes pull out of subject <a> tag

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 23, 2009, 20:43 UTC
Message-ID: <cb7bb73a0908231343k3546682ge05cc4f3c3d83638@mail.gmail.com>
In-Reply-To: <200908232213.48786.jnareb@gmail.com>

2009/8/23 Jakub Narebski <jnareb@gmail.com>:

Show 9 quoted lines

> For format_subject_html which you are fixing, and which is used by
> 'shortlog', 'history' and 'tags' views this didn't cause much changes
> in layout.  But the way gitweb uses git_print_header_div in views such
> as 'tree', 'blob' etc., where the outer (containing) link is made into
> *block* element[1] by the way of CSS (display: block) makes layout
> (visualisation) very screwed up in older browser.  But I don't expect
> you to fix that.
>
> [1] Originally so the area to click is larger.

Fixing that really needs some kind of ridiculously complex workarounds, or a totally different layout. That is actually one of the situations where nested links make perfect sense, and it's a real pity the standard wouldn't allow them, and that some client actually altered the DOM to 'fix' it. But anyway.

> Signoff?

Aaaargh. Is it enough if I put it here:

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

or should I resend?

(One would expect I actually learned to add it, finally, but noooo ... gah, stupid me.)

Show 15 quoted lines

>> The next step would be to find a way to layout decently the case when
>> some shortlog entries have a _humongous_ amount of ref markers. See
>> for example http://git.oblomov.eu/acecad/shortlog
>>
>> I honestly doubt these cases happen in normal git repositories, but it
>> might still be worth taking them into consideration. Possibilities
>> include hard-limiting the title column maximum width (in browsers for
>> which the corresponding attributes and rules work), manual insertion of
>> hard line breaks <br/> every n-th ref marker, or something more dynamic
>> such as hiding most of the ref markers when they are more than, say, 5,
>> and showing them on hover.
>>
>> Suggestions? Comments?
>
> Perhaps limiting to heads and tags if there are too many refs?

That wouldn't help at all in the case I linked: http://git.oblomov.eu/acecad/shortlog due to the number of tags that were imported from CVS.

-- 
Giuseppe "Oblomov" Bilotta