Re: [PATCH] gitweb: pull ref markes pull out of subject <a> tag

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 23, 2009, 22:31 UTC
Message-ID: <7vzl9qqi11.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0908231343k3546682ge05cc4f3c3d83638@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

Show 22 quoted lines

> 2009/8/23 Jakub Narebski <jnareb@gmail.com>:
>> For format_subject_html which you are fixing, and which is used by
>> 'shortlog', 'history' and 'tags' views this didn't cause much changes
>> in layout.  But the way gitweb uses git_print_header_div in views such
>> as 'tree', 'blob' etc., where the outer (containing) link is made into
>> *block* element[1] by the way of CSS (display: block) makes layout
>> (visualisation) very screwed up in older browser.  But I don't expect
>> you to fix that.
>>
>> [1] Originally so the area to click is larger.
>
> Fixing that really needs some kind of ridiculously complex
> workarounds, or a totally different layout. That is actually one of
> the situations where nested links make perfect sense, and it's a real
> pity the standard wouldn't allow them, and that some client actually
> altered the DOM to 'fix' it. But anyway.
>
>> Signoff?
>
> Aaaargh. Is it enough if I put it here:
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

I can manage.

Thanks, both.