git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 3/3] gitweb: gravatar url cache

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jun 24, 2009, 22:46 UTC
Message-ID
<cb7bb73a0906241546x6b6164e7w4e6c6601d1119032@mail.gmail.com>
In-Reply-To
<7v63elqoig.fsf@alter.siamese.dyndns.org>
On Thu, Jun 25, 2009 at 12:02 AM, Junio C Hamano<gitster@pobox.com> wrote:
Show 8 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> Views which contain many occurrences of the same email address (e.g.
>> shortlog view) benefit from not having to recalculate the MD5 of the
>> email address every time.
>> ---
>
> Sign-off?
Duh.
> I think the cache is placed at the wrong level (it doesn't have to be a
> GRavatar_url_cache, but can be a general avatar_url_cache).

I'm not sure about it. The URL depends on email and size (can you use arrays as hash keys in Perl?) , and the email part might be the same but the size part might differ across separate calls (in theory; in practice avatars in a view are presently all the same size; but for example if we were to autodetect email addresses in commit messages, we might have both single- and double- sided avatars in the same page). By hashing on email+size only we would lose the benefit of cache when using the same avatar at separate sizes.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Junio C HamanoNext: Jacob Helwig
Message 6 of 12 in “[PATCHv5 0/3] gitweb: gravatar support”
  1. Giuseppe BilottaJun 24, 2009
  2. 1/3 gitweb: refactor author name insertionGiuseppe Bilotta, Jun 24, 2009
  3. 2/3 gitweb: gravatar supportGiuseppe Bilotta, Jun 24, 2009
  4. 3/3 gitweb: gravatar url cacheGiuseppe Bilotta, Jun 24, 2009
  5. Junio C HamanoJun 24, 2009
  6. Giuseppe BilottaJun 24, 2009
  7. Jacob HelwigJun 24, 2009
  8. Giuseppe BilottaJun 24, 2009
  9. 3/3 gitweb: gravatar url cacheGiuseppe Bilotta, Jun 24, 2009
  10. Junio C HamanoJun 25, 2009
  11. Jakub NarebskiJun 25, 2009
  12. Giuseppe BilottaJun 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.