Re: [PATCHv2 5/6] gitweb: last-modified time should be commiter, not author

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 11, 2009, 09:54 UTC
Message-ID: <cb7bb73a0902110154h325ed146h4d1161d4a8dcb1ca@mail.gmail.com>
In-Reply-To: <200902111018.39699.jnareb@gmail.com>

On Wed, Feb 11, 2009 at 10:18 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 26 quoted lines

> On Wed, 11 Feb 2009, Giuseppe Bilotta wrote:
>> On Wed, Feb 11, 2009 at 4:10 AM, Deskin Miller <deskinm@gmail.com> wrote:
>>> git reflog?
>>>
>>> Seems like one could find the oldest time the commit appears in the
>>> reflog, for the branch one is interested in.  You can use the commit
>>> time to limit the search through the reflog, but there would be clock
>>> skew concerns.
>>
>> Bingo! Thanks a lot
>>
>> oblomov@rbot ~ $ GIT_DIR=/var/git/rbot.git/ git reflog show
>> --since="two days ago" master | cat
>> 7324b32... master@{0}: push
>> e2dc08d... master@{1}: push
>> oblomov@rbot ~ $ GIT_DIR=/var/git/rbot.git/ git reflog show
>> --since="yesterday" master | cat
>> oblomov@rbot ~ $
>>
>> I'll try to work it in the next review for this patchset.
>
> Assuming that you have reflog enabled (yes, it is default now)...
> So you would have to provide fallback in the case there is no reflog.
>
> BTW. "git reflog" is porcelain; it would be better to parse reflog
> directly, I think.

Does disabling reflog remove old reflogs? IOW, can I check if reflog is enabled just by opening the reflog file and assuming reflog isn't enabled if it's not there? Falling back to the commit date would still work decently.

Since we're only interested in the last reflog date, what we can do is to read the last line and get the unix time which is held two places before the tab separating the metadata from the log message. Correct?

-- 
Giuseppe "Oblomov" Bilotta