Re: [PATCHv2 1/6] gitweb: channel image in rss feed

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 6, 2009, 10:55 UTC
Message-ID: <cb7bb73a0902060255i6645fc25wf16755a866ab7a42@mail.gmail.com>
In-Reply-To: <200902042356.34407.jnareb@gmail.com>

On Wed, Feb 4, 2009 at 11:56 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 14 quoted lines

>> +             if (defined $logo || defined $favicon) {
>> +                     # prefer the logo to the favicon, since RSS
>> +                     # doesn't allow both
>> +                     my $img = esc_url($logo || $favicon);
>> +                     print "<image>\n" .
>> +                           "<url>$img</url>\n" .
>> +                           "<title>$title</title>\n" .
>> +                           "<link>$alt_url</link>\n" .
>> +                           "</image>\n";
>> +             }
>
> A question: how should URL, which is _contents_ of a tag (instead of
> as _attribute_ value), quoted (escaped)? I don't think it is specified
> in RSS. I guess that using esc_url() is a safe solution.

Indeed, it might not be needed, but it's doesn't do any damage to escape the URL.

-- 
Giuseppe "Oblomov" Bilotta