git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: last-modified time should be commiter, not author

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jan 26, 2009, 11:43 UTC
Message-ID
<cb7bb73a0901260343leebb09fld144f1dec7c8470a@mail.gmail.com>
In-Reply-To
<200901260254.49919.jnareb@gmail.com>
On Mon, Jan 26, 2009 at 2:54 AM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 9 quoted lines
> On Sun, 25 Jan 2009, Giuseppe Bilotta wrote:
>
>> Subject: [PATCH] gitweb: last-modified time should be commiter, not author
>
> Should be really either "[PATCH 1/2]" or "[PATCH 5/4]" or "[PATCH 5/6]"
> just in case for the next patch, because next patch _depends_ on this
> one, and just in case of threading problem it should be marked as it;
> it also makes easier to apply patches from emails saved as individual
> files each.
I'll resend the whole 6-patch series cc'ing Junio too
Show 6 quoted lines
>> Use the committer time for the last-modified header to ensure a more
>> correct guess of the last time the repository was modified.
>
> Good catch, good thinking IMHO. Committer date has much better chance
> to be monotonic than author date, and is more close related to
> _publishing_ date (author date is more of _creation_ date).

BTW, it is still not good enough. Consider a remote repo to which you just pushed some changes you commited last week. The last-modified date would be last-week, even if you just pushed those changes.

This used to be a problem for us on ruby-rbot because even when watching the feed we would get no updates on the irc channel (the bot thought the feed could still be cached). the if-modified thing seems to have fixed this though.

Show 9 quoted lines
> Lack signoff; if Junio forges it (or you reply that it should be
> signed off), you can add from me
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
>
>
> P.S. I wonder what other web interfaces do, for example cgit. I guess
> that web interfaces for other SCMs like SVN::Web, ViewVC etc. do not
> have this problem because they have only one, single date.

HEAD'ing a cgit atom url gives a last-modified date one hour from the request, it seems. This is actually a typical (and not nice) behaviour of many CGI scripts.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 12 of 13 in “gitweb feed metadata tuneups”
  1. 0/4 gitweb feed metadata tuneupsGiuseppe Bilotta, Jan 23, 2009
  2. 1/4 gitweb: channel image in rss feedGiuseppe Bilotta, Jan 23, 2009
  3. 2/4 gitweb: feed generator metadataGiuseppe Bilotta, Jan 23, 2009
  4. 3/4 gitweb: rss feed managingEditorGiuseppe Bilotta, Jan 23, 2009
  5. 4/4 gitweb: rss channel dateGiuseppe Bilotta, Jan 23, 2009
  6. gitweb: last-modified time should be commiter, not authorGiuseppe Bilotta, Jan 25, 2009
  7. gitweb: check if-modified-since for feedsGiuseppe Bilotta, Jan 25, 2009
  8. Jakub NarebskiJan 26, 2009
  9. Giuseppe BilottaJan 26, 2009
  10. Jakub NarebskiFeb 2, 2009
  11. Jakub NarebskiJan 26, 2009
  12. Giuseppe BilottaJan 26, 2009
  13. Jakub NarebskiJan 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.