[PATCH] gitweb: last-modified time should be commiter, not author
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Jan 25, 2009, 22:42 UTC
- Message-ID
- <1232923370-4427-1-git-send-email-giuseppe.bilotta@gmail.com>
- In-Reply-To
- <1232686121-1800-5-git-send-email-giuseppe.bilotta@gmail.com>
The last-modified time header added by RSS to increase cache hits from readers should be set to the date the repository was last modified. The author time in this respect is not a good guess because the last commit might come from a oldish patch.
Use the committer time for the last-modified header to ensure a more correct guess of the last time the repository was modified. --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 756868a..8c49c75 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -6015,7 +6015,7 @@ sub git_feed { } if (defined($commitlist[0])) { %latest_commit = %{$commitlist[0]}; - %latest_date = parse_date($latest_commit{'author_epoch'}); + %latest_date = parse_date($latest_commit{'committer_epoch'}); print $cgi->header( -type => $content_type, -charset => 'utf-8',
-- 1.5.6.5