git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] gitweb: Fix nested links problem with ref markers

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jan 14, 2009, 13:52 UTC
Message-ID
<cb7bb73a0901140552k6de6f48udd77205b918f30@mail.gmail.com>
In-Reply-To
<200901141139.42263.jnareb@gmail.com>
On Wed, Jan 14, 2009 at 5:39 AM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 32 quoted lines
> On Wed, 14 Jan 2009, Giuseppe Bilotta wrote:
>> On Tue, Jan 13, 2009 at 7:17 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>>> On Tue, 13 Jan 2009, Giuseppe Bilotta wrote:
>
>>>> Can you provide a patch I can apply to my tree for testing to see how
>>>> it comes up?
>>>
>>> Here it is. Note that CSS could be I think reduced. The size of
>>> gitweb.perl changes is affected by changing calling convention for
>>> git_print_header_html subroutine.
>>
>> It's funny, I was working on a very similar patch myself a couple of
>> days ago, but couldn't get the horizontal filler after the link to
>> work properly, which is why I asked on www-style.
>>
>> I'll test your patch and let you know.
>
> I am checking 'log' view of git repository; it should have enough
> ref markers to test this issue.
>
> It works also in Konqueror 3.5.3-0.2.fc4...
>
>>> There is also strange artifact at least in Mozilla 1.17.2: if I hover
>>> over ref marker, the subject (title) gets darker background. Curious...
>>
>> Might be some kind of bug with the capturing vs bubbling phase.
>
> ...but the same artifact can be seen too.  Also I am not entirely
> pleased with the way things behave on mouseover.  It is a pity that
> you cannot style element using CSS2.1 based on the pseudo-class :hover
> of descendant element, or/and pseudo-class of sibling element, which
> nevertheless overlays given element.

I know, I've been needing something like this in other occasion. And that's precisely what I was talking about for the limits of CSS, and why I really wonder if the illegal XHMTL but valid XML shouldn't rather be our option ...

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub Narebski
Message 8 of 8 in “[BUG/RFH] gitweb: Trouble with ref markers being hyperlinks because of illegally nested links”
  1. Jakub NarebskiJan 12, 2009
  2. Giuseppe BilottaJan 12, 2009
  3. Jakub NarebskiJan 13, 2009
  4. Giuseppe BilottaJan 13, 2009
  5. gitweb: Fix nested links problem with ref markersJakub Narebski, Jan 14, 2009
  6. Giuseppe BilottaJan 14, 2009
  7. Jakub NarebskiJan 14, 2009
  8. Giuseppe BilottaJan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.