git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] gitweb: Fix nested links problem with ref markers

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Jan 14, 2009, 03:56 UTC
Message-ID
<cb7bb73a0901131956s7f441c38o3a0b1e5f456a3cd3@mail.gmail.com>
In-Reply-To
<200901140117.38803.jnareb@gmail.com>
On Tue, Jan 13, 2009 at 7:17 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 12 quoted lines
> On Tue, 13 Jan 2009, Giuseppe Bilotta wrote:
>> On Mon, Jan 12, 2009 at 7:13 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>>> On Mon, 12 Jan 2009, Giuseppe Bilotta wrote:
>>>> On Sun, Jan 11, 2009 at 8:15 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> [...]
>> Notice that nested links are actually valid *XML*. Indeed, I asked on
>> www-style and they suggested leaving the problem as-is, serving as
>> html+xml which is what we do.
>
> But nested links are neither valid HTML nor valid XHTML.  This
> restriction (no nested links) is IMVHO quite sensible

Sensible? I think it's idiotic, especially since CSS does not and cannot provide enough expression power to obtain the same layout and functionality as what can be achieved by nesting links, so that to achieve these results one has to resort to horirble trickes, effectively destroying the whole purporse of HTML+CSS which is to separate layout from semantics.

But anyway.
>> The float thing was the second suggestion I was given on www-style.
>
> What was the first suggestion? And what is www-style?

The first suggestion was to just leave things as they are. www-style is www-style@w3c.org, the CSS mailing list of the W3C

Show 6 quoted lines
>> Can you provide a patch I can apply to my tree for testing to see how
>> it comes up?
>
> Here it is. Note that CSS could be I think reduced. The size of
> gitweb.perl changes is affected by changing calling convention for
> git_print_header_html subroutine.

It's funny, I was working on a very similar patch myself a couple of days ago, but couldn't get the horizontal filler after the link to work properly, which is why I asked on www-style.

I'll test your patch and let you know.
> There is also strange artifact at least in Mozilla 1.17.2: if I hover
> over ref marker, the subject (title) gets darker background. Curious...
Might be some kind of bug with the capturing vs bubbling phase.
-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 6 of 8 in “[BUG/RFH] gitweb: Trouble with ref markers being hyperlinks because of illegally nested links”
  1. Jakub NarebskiJan 12, 2009
  2. Giuseppe BilottaJan 12, 2009
  3. Jakub NarebskiJan 13, 2009
  4. Giuseppe BilottaJan 13, 2009
  5. gitweb: Fix nested links problem with ref markersJakub Narebski, Jan 14, 2009
  6. Giuseppe BilottaJan 14, 2009
  7. Jakub NarebskiJan 14, 2009
  8. Giuseppe BilottaJan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.