git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFCv2 1/2] gitweb: add patch view

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 3, 2008, 13:14 UTC
Message-ID
<cb7bb73a0812030514u11e10bebue5a1451d54fc3f96@mail.gmail.com>
In-Reply-To
<200812031400.50980.jnareb@gmail.com>
On Wed, Dec 3, 2008 at 2:00 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 17 quoted lines
> On Wed, 3 Dec 2008, Giuseppe Bilotta wrote:
>> On Wed, Dec 3, 2008 at 12:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>> Perhaps this configuration should also be a feature defined in %feature,
>>> overridable by each repository?  If you default it to "disabled" (as any
>>> new feature typically does), you do not have to yank a random number such
>>> as 100 out of thin air.
>>
>> I thought about it, but then I thought it was way too useful for
>> single patches to disable the feature a priori. I'd rather make the
>> default limit much smaller (like the original 16 commits I had in
>> mind, or even less).
>
> Perhaps %feature can be used to configure _maximum_ number of patches
> in 'patch' / 'format_patch' view (gitweb_get_feature... well, sort of
> as gitweb_check_feature would work too), rather than checking if it
> is enabled or disabled?

The way it's implemented in v2, you just need to set $patch_max in your local or system config file (e.g. /etc/gitweb.conf). I'm not sure about the benefit we would gain in going through %feature.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 7 of 9 in “[RFCv2 0/2] gitweb: patch view”
  1. Giuseppe BilottaDec 3, 2008
  2. 1/2 gitweb: add patch viewGiuseppe Bilotta, Dec 3, 2008
  3. 2/2 gitweb: links to patch action in commitdiff and shortlog viewGiuseppe Bilotta, Dec 3, 2008
  4. Junio C HamanoDec 3, 2008
  5. Giuseppe BilottaDec 3, 2008
  6. Jakub NarebskiDec 3, 2008
  7. Giuseppe BilottaDec 3, 2008
  8. Jakub NarebskiDec 3, 2008
  9. Giuseppe BilottaDec 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.