git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFCv2 1/2] gitweb: add patch view

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 3, 2008, 11:33 UTC
Message-ID
<cb7bb73a0812030333n2cfdc745m3a910d2e8677e7fe@mail.gmail.com>
In-Reply-To
<7vbpvtecb6.fsf@gitster.siamese.dyndns.org>
On Wed, Dec 3, 2008 at 12:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> We thus create a new view that can be fed to git-am directly by exposing
>> the output of git format-patch directly. This allows patch exchange and
>> submission via gitweb. A hard limit (configurable, defaults to 100) is
>> imposed on the number of commits which will be included in a patchset,
>> to prevent DoS attacks on the server.
>
> Hmm, I would imagine that "snapshot" would be a much more effective way to
> do such an attack, and notice the way we prevent it is to selectively
> enable the feature per repository.
>
> Perhaps this configuration should also be a feature defined in %feature,
> overridable by each repository?  If you default it to "disabled" (as any
> new feature typically does), you do not have to yank a random number such
> as 100 out of thin air.

I thought about it, but then I thought it was way too useful for single patches to disable the feature a priori. I'd rather make the default limit much smaller (like the original 16 commits I had in mind, or even less).

-- 
Giuseppe "Oblomov" Bilotta
Previous: Junio C HamanoNext: Jakub Narebski
Message 5 of 9 in “[RFCv2 0/2] gitweb: patch view”
  1. Giuseppe BilottaDec 3, 2008
  2. 1/2 gitweb: add patch viewGiuseppe Bilotta, Dec 3, 2008
  3. 2/2 gitweb: links to patch action in commitdiff and shortlog viewGiuseppe Bilotta, Dec 3, 2008
  4. Junio C HamanoDec 3, 2008
  5. Giuseppe BilottaDec 3, 2008
  6. Jakub NarebskiDec 3, 2008
  7. Giuseppe BilottaDec 3, 2008
  8. Jakub NarebskiDec 3, 2008
  9. Giuseppe BilottaDec 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.