git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git rev-list --author/--committer b0rked with -F/--fixed-strings

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Sep 4, 2008, 13:46 UTC
Message-ID
<cb7bb73a0809040646l25737a82jf380b4e17ef103f1@mail.gmail.com>
In-Reply-To
<7v4p4w75b7.fsf@gitster.siamese.dyndns.org>
On Thu, Sep 4, 2008 at 9:12 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Because we allow you to give "-F" and "--author=foo" in any order, looking
> at the options we have seen already and adjusting the pattern depending on
> the fixed-string option in the code would not be workable.  You would have
> to instead queue up all the --grep/--author/--committer options until the
> very end and _then_ compile them at the end, after you saw all the other
> grep related options such as -i/-F/-E

I suspected as much ... basically the idea would be to transform fixed-string searches into auto-quoted regexp matches, right? I wonder what kind of speed hit this would give.

> I am not interested in helping people with attitude very much ;-)

Ouch, I'm sorry. Did I come through as having an attitude? The reason why I specified I thought it was a bug was because, as you specified, regexps are actually necessary with --author etc, so one might consider it a simple flag incompatibility. Sorry.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Junio C Hamano
Message 13 of 13 in “git rev-list --author/--committer b0rked with -F/--fixed-strings”
  1. Giuseppe BilottaSep 4, 2008
  2. Junio C HamanoSep 4, 2008
  3. Teach "log -F --author=<match>" to behave betterJunio C Hamano, Sep 4, 2008
  4. Teemu LikonenSep 4, 2008
  5. Junio C HamanoSep 4, 2008
  6. Teemu LikonenSep 4, 2008
  7. Junio C HamanoSep 5, 2008
  8. Giuseppe BilottaSep 4, 2008
  9. Petr BaudisSep 4, 2008
  10. Junio C HamanoSep 4, 2008
  11. --all-matchTeemu Likonen, Sep 5, 2008
  12. Junio C HamanoSep 5, 2008
  13. Giuseppe BilottaSep 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.