From: Giuseppe Bilotta Date: Thu, 04 Sep 2008 13:46:52 GMT Subject: Re: git rev-list --author/--committer b0rked with -F/--fixed-strings Message-ID: In-Reply-To: <7v4p4w75b7.fsf@gitster.siamese.dyndns.org> On Thu, Sep 4, 2008 at 9:12 AM, Junio C Hamano wrote: > Because we allow you to give "-F" and "--author=foo" in any order, looking > at the options we have seen already and adjusting the pattern depending on > the fixed-string option in the code would not be workable. You would have > to instead queue up all the --grep/--author/--committer options until the > very end and _then_ compile them at the end, after you saw all the other > grep related options such as -i/-F/-E I suspected as much ... basically the idea would be to transform fixed-string searches into auto-quoted regexp matches, right? I wonder what kind of speed hit this would give. > I am not interested in helping people with attitude very much ;-) Ouch, I'm sorry. Did I come through as having an attitude? The reason why I specified I thought it was a bug was because, as you specified, regexps are actually necessary with --author etc, so one might consider it a simple flag incompatibility. Sorry. -- Giuseppe "Oblomov" Bilotta