Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Aug 3, 2008, 13:14 UTC
Message-ID: <cb7bb73a0808030614v260dea2ek6757b7a22b13afa2@mail.gmail.com>
In-Reply-To: <20080803120350.GW32184@machine.or.cz>

On Sun, Aug 3, 2008 at 2:03 PM, Petr Baudis <pasky@suse.cz> wrote:

Show 16 quoted lines

> On Sat, Aug 02, 2008 at 05:39:14PM +0200, Giuseppe Bilotta wrote:
>> This patch turns ref markers for tags and heads into links to
>> shortlog/refname. Appropriate changes are made in the CSS to prevent ref
>> markers to be annoyingly blue and underlined.
>>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> I think this is good idea in principle, but
>
>        (i) Why not do this for all the refs?
>
>        (ii) I think you should decide on the type of the action based
> on the object type of the ref; actually, any kind of object type can be
> ref'd, and for tags you would rather want tag view, etc. (The tag view
> actually sucks and should behave more like git show tag - i.e. append
> the appropriate view after the tag info - but that is different matter.)

Funny that. My original plan was to have a different action depending on tag (I tried shortlog for tag and commitdiff for branch). And since I I had no idea what kind of action to use for 'generic' refs, I left them out. Then I had second thoughts and started using shortlog for both heads and tags, and collapsed the code but still kept the generic refs out of the way. So maybe we can use shortlog as default action and single out tags (and whatever else we'll find to need a different action)?

-- 
Giuseppe "Oblomov" Bilotta