Re: [PATCH] gitweb: ref markers link to named shortlogs

From: Petr Baudis <pasky@suse.cz>
Date: Aug 3, 2008, 12:03 UTC
Message-ID: <20080803120350.GW32184@machine.or.cz>
In-Reply-To: <1217691554-10407-1-git-send-email-giuseppe.bilotta@gmail.com>

On Sat, Aug 02, 2008 at 05:39:14PM +0200, Giuseppe Bilotta wrote:

Show 5 quoted lines

> This patch turns ref markers for tags and heads into links to
> shortlog/refname. Appropriate changes are made in the CSS to prevent ref
> markers to be annoyingly blue and underlined.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

I think this is good idea in principle, but

	(i) Why not do this for all the refs?

	(ii) I think you should decide on the type of the action based
on the object type of the ref; actually, any kind of object type can be
ref'd, and for tags you would rather want tag view, etc. (The tag view
actually sucks and should behave more like git show tag - i.e. append
the appropriate view after the tag info - but that is different matter.)

-- 
				Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC.  -- Bill Gates