Re: [PATCH/RFC 0/4] Add option to enable filters in git-svn

From: Matteo Bertini <naufraghi@develer.com>
Date: May 31, 2016, 20:34 UTC
Message-ID: <cb49a08e3ec44f7d37603e5b1fe20a22@develer.com>
In-Reply-To: <20160531181241.GA28818@dcvr.yhbt.net>

Il 2016-05-31 20:12 Eric Wong ha scritto:

> Matteo Bertini <naufraghi@develer.com> wrote:
>> Sorry to all, but I missed a Checksum mismatch error, I'll have a
>> look and submit an update.

I've had a look, the problem is a missing smudge filter. Unluckily the small svn revision range i was using was never updating a filtered file.

The code actually uses `cat-file --batch` to get the blobs, but the stored blob is not what SVN::TxDelta::apply need. What I need is the smudged blob, but cat-file does not supports it.

I can modify cat-file with a new option to call `convert_to_working_tree`, and have the filters applied, for example --use-filters, that expects an extra field, like $sha\t$path, in the stdin stream.

I don't like a lot putting an high level feature in a low level command, but --textconv seems very similar to this.

Opinions or other suggestions?

> Sure, when you reroll can you also ensure lines are wrapped at
> 80 cols or less? (at least for the git-svn code, but probably
> for the rest of it, too).

Sure

> As for the option name, the "enable" prefix doesn't seem
> right.  We already have some "use" prefixes (use-svm-props),
> so maybe "--use-filters" is better.

Ok

> I haven't looked into filters at all, yet, but you can probably
> use the existing rot13 filter in t0021 for writing tests.

Thanks for the pointer, I'll have a look.

-- 
Matteo Bertini - naufraghi@develer.com
Develer S.r.l. - http://www.develer.com/
.hardware .software .innovation
Tel.: +39 055 3986627 - ext.: 211