Re: [PATCH/RFC 0/4] Add option to enable filters in git-svn
- From
- Eric Wong <e@80x24.org>
- Date
- May 31, 2016, 18:12 UTC
- Message-ID
- <20160531181241.GA28818@dcvr.yhbt.net>
- In-Reply-To
- <33130d8be1ad6edaa75a75c43901a2fa@develer.com>
Matteo Bertini <naufraghi@develer.com> wrote:
> Sorry to all, but I missed a Checksum mismatch error, I'll have a > look and submit an update.
Sure, when you reroll can you also ensure lines are wrapped at 80 cols or less? (at least for the git-svn code, but probably for the rest of it, too).
As for the option name, the "enable" prefix doesn't seem right. We already have some "use" prefixes (use-svm-props), so maybe "--use-filters" is better.
I haven't looked into filters at all, yet, but you can probably use the existing rot13 filter in t0021 for writing tests.
Thanks.