git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff --no-index: fix -R with stdin

From
Martin Storsjö <martin@martin.st>
Date
Sep 11, 2023, 19:20 UTC
Message-ID
<c9d3184f-24ac-af75-f31e-aa63c788bfb3@martin.st>
In-Reply-To
<22fdfa3b-f90e-afcc-667c-705fb7670245@web.de>
On Sun, 10 Sep 2023, René Scharfe wrote:
Show 11 quoted lines
> When -R is given, queue_diff() swaps the mode and name variables of the
> two files to produce a reverse diff.  1e3f26542a (diff --no-index:
> support reading from named pipes, 2023-07-05) added variables that
> indicate whether files are special, i.e named pipes or - for stdin.
> These new variables were not swapped, though, which broke the handling
> of stdin with with -R.  Swap them like the other metadata variables.
>
> Reported-by: Martin Storsjö <martin@martin.st>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Great bug report, thank you!
Thanks for the extremely swift response and fix!
// Martin
Previous: Taylor BlauNext: Junio C Hamano
Message 5 of 6 in “Regression in git diff with stdin, with -R”
  1. Martin StorsjöSep 9, 2023
  2. diff --no-index: fix -R with stdinRené Scharfe, Sep 9, 2023
  3. Phillip WoodSep 10, 2023
  4. Taylor BlauSep 10, 2023
  5. Martin StorsjöSep 11, 2023
  6. Junio C HamanoSep 11, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.