Re: [PATCH] diff --no-index: fix -R with stdin
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Sep 10, 2023, 18:41 UTC
- Message-ID
- <ZP4N7c92ra5ZOKl8@nand.local>
- In-Reply-To
- <22fdfa3b-f90e-afcc-667c-705fb7670245@web.de>
On Sun, Sep 10, 2023 at 12:12:52AM +0200, René Scharfe wrote:
Show 11 quoted lines
> When -R is given, queue_diff() swaps the mode and name variables of the > two files to produce a reverse diff. 1e3f26542a (diff --no-index: > support reading from named pipes, 2023-07-05) added variables that > indicate whether files are special, i.e named pipes or - for stdin. > These new variables were not swapped, though, which broke the handling > of stdin with with -R. Swap them like the other metadata variables. > > Reported-by: Martin Storsjö <martin@martin.st> > Signed-off-by: René Scharfe <l.s.r@web.de> > --- > Great bug report, thank you!
Great patch ;-). LGTM!
Thanks, Taylor