git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions

From
Marc Branchaud <marcnarc@xiplink.com>
Date
May 11, 2017, 19:22 UTC
Message-ID
<c9a878df-1c3e-09ad-3b48-aa123123622b@xiplink.com>
In-Reply-To
<20170509032238.uvgg7sezfzlig2ko@sigill.intra.peff.net>
On 2017-05-08 11:22 PM, Jeff King wrote:
Show 10 quoted lines
> On Mon, May 08, 2017 at 12:03:37PM -0400, Marc Branchaud wrote:
>
>> This matches how the diff Porcelain works.  It makes the plumbing commands
>> respect diff's configuration options, such as indentHeuristic, because
>> init_revisions() calls diff_setup() which fills in the diff_options struct.
>
> I don't know if you want to note here that this is only _some_ options.
> I.e., ones that we handle by copying via diff_setup(). Maybe it's
> obvious from the description already (it's hard for me to tell because I
> already know it either way :) ).

(shrug) I'm fine with the way it is, but I'd also be OK with "respect some of diff's configuration options".

Junio, please feel free to reword the message if you like. Or I can send out a v5, if that's easier for you.

		M.
Previous: Jeff KingNext: Marc Branchaud
Message 9 of 14 in “What's cooking in git.git (May 2017, #02; Mon, 8)”
  1. Junio C HamanoMay 8, 2017
  2. Enabling the diff "indent" heuristic by defaultMarc Branchaud, May 8, 2017
  3. 0/4 Make diff plumbing commands respect the indentHeuristic.Marc Branchaud, May 8, 2017
  4. 1/4 diff: make the indent heuristic part of diff's basic configurationMarc Branchaud, May 8, 2017
  5. 4/4 add--interactive: drop diff.indentHeuristic handlingMarc Branchaud, May 8, 2017
  6. Jeff KingMay 9, 2017
  7. 2/4 diff: have the diff-* builtins configure diff before initializing revisionsMarc Branchaud, May 8, 2017
  8. Jeff KingMay 9, 2017
  9. Marc BranchaudMay 11, 2017
  10. 3/4 diff: enable indent heuristic by defaultMarc Branchaud, May 8, 2017
  11. Stefan BellerMay 8, 2017
  12. Jeff KingMay 9, 2017
  13. Jeff KingMay 9, 2017
  14. Jeff KingMay 9, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.