Re: [PATCH v4 0/4] Make diff plumbing commands respect the indentHeuristic.

From: Jeff King <peff@peff.net>
Date: May 9, 2017, 03:27 UTC
Message-ID: <20170509032729.bhq6ui23c3p6oyz3@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kbLKQ0jS0xfQO1MSp5T2_m9dShx0oYeTDAjDdUcydm3uQ@mail.gmail.com>

On Mon, May 08, 2017 at 10:13:41AM -0700, Stefan Beller wrote:

Show 8 quoted lines

> > -test_expect_success 'diff: nice spaces with diff.indentHeuristic' '
> > +test_expect_success 'diff: nice spaces with diff.indentHeuristic=true' '
> 
> Adding the '=true' seems weird to me (I'd think the true is implied,
> similar to C,
> where we do "if (!null_pointer)" instead of an explicit "!=null".
> However we do have these '=true' sprinkled all over the tests,
> so I guess it is a valid dialect in our test suite.

I think it's better to be explicit here. I think the original was less about "implied true", as it was making the assumption that the feature was off in the first place. Now that we've flipped that, just saying "diff.indentHeuristic" is unclear whether you mean the "implied true" of:

  git -c diff.indentHeuristic diff ...

or if you mean setting diff.indentHeuristic at all but aren't saying which (which I think is how the original meant it).

I dunno. I guess it is subjective, but IMHO the "=true" is much clearer.

-Peff