git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/4] commit-graph.c: write non-split graphs as read-only

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 29, 2020, 11:52 UTC
Message-ID
<c88a9169-47fd-2fdf-823e-d69d59f406d1@gmail.com>
In-Reply-To
<xmqqmu6vyz4q.fsf@gitster.c.googlers.com>
On 4/28/2020 7:22 PM, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
> 
>> On Tue, Apr 28, 2020 at 03:44:13PM -0600, Taylor Blau wrote:
>>
>>> What do you want to do about the final patch that I stuck on the end of
>>> this series in [1]? If I don't hear from anybody, I'll send it as 5/5 in
>>> v3 and we can feel free to not apply it if it's controversial.
>>
>> I have to admit I don't care that much either way about it (see my
>> earlier response on three mental models). I'm happy for you or Junio to
>> decide. :)
> 
> My gut feeling is that our longer term goal (if we had timeperiod
> during which the codebase is quiescent enough and infinite energy to
> dedicate on code clean-up) among one or your options should be to
> consistently create files that are rewritten-and-renamed read-only,
> to discourage casual tampering, so I am OK with that 5th patch.
> 
> Having said that, I suspect that Derrick and friends are larger
> stakeholders in the "chain" file, so I'd prefer to see us basing
> the choice on their input.

I'm happy with how this discussion has gone. I'm sure the only reason for the permissions I wrote was because I found them somewhere else in the codebase and I copied them from there. Memory is fuzzy, but I can guarantee the deviation from the norm was not in purpose.

Thanks, -Stolee

Previous: Junio C HamanoNext: Taylor Blau
Message 26 of 36 in “commit-graph: write non-split graphs as read-only”
  1. 0/3 commit-graph: write non-split graphs as read-onlyTaylor Blau, Apr 20, 2020
  2. 1/3 tempfile.c: introduce 'create_tempfile_mode'Taylor Blau, Apr 20, 2020
  3. Junio C HamanoApr 20, 2020
  4. 2/3 lockfile.c: introduce 'hold_lock_file_for_update_mode'Taylor Blau, Apr 20, 2020
  5. 3/3 commit-graph.c: write non-split graphs as read-onlyTaylor Blau, Apr 20, 2020
  6. Junio C HamanoApr 20, 2020
  7. Taylor BlauApr 20, 2020
  8. Junio C HamanoApr 21, 2020
  9. Jeff KingApr 21, 2020
  10. Junio C HamanoApr 21, 2020
  11. 0/4 commit-graph: write non-split graphs as read-onlyTaylor Blau, Apr 27, 2020
  12. 1/4 tempfile.c: introduce 'create_tempfile_mode'Taylor Blau, Apr 27, 2020
  13. 2/4 lockfile.c: introduce 'hold_lock_file_for_update_mode'Taylor Blau, Apr 27, 2020
  14. 3/4 commit-graph.c: write non-split graphs as read-onlyTaylor Blau, Apr 27, 2020
  15. Junio C HamanoApr 27, 2020
  16. Taylor BlauApr 27, 2020
  17. Junio C HamanoApr 28, 2020
  18. Jeff KingApr 28, 2020
  19. Junio C HamanoApr 28, 2020
  20. Jeff KingApr 28, 2020
  21. Junio C HamanoApr 28, 2020
  22. Jeff KingApr 28, 2020
  23. Taylor BlauApr 28, 2020
  24. Jeff KingApr 28, 2020
  25. Junio C HamanoApr 28, 2020
  26. Derrick StoleeApr 29, 2020
  27. 4/4 commit-graph.c: ensure graph layers respect core.sharedRepositoryTaylor Blau, Apr 27, 2020
  28. Taylor BlauApr 27, 2020
  29. Jeff KingApr 27, 2020
  30. 0/5 commit-graph: write non-split graphs as read-onlyTaylor Blau, Apr 29, 2020
  31. 1/5 tempfile.c: introduce 'create_tempfile_mode'Taylor Blau, Apr 29, 2020
  32. 2/5 lockfile.c: introduce 'hold_lock_file_for_update_mode'Taylor Blau, Apr 29, 2020
  33. 3/5 commit-graph.c: write non-split graphs as read-onlyTaylor Blau, Apr 29, 2020
  34. 4/5 commit-graph.c: ensure graph layers respect core.sharedRepositoryTaylor Blau, Apr 29, 2020
  35. 5/5 commit-graph.c: make 'commit-graph-chain's read-onlyTaylor Blau, Apr 29, 2020
  36. Jeff KingMay 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.