Re: [PATCH v2 3/4] commit-graph.c: write non-split graphs as read-only

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 27, 2020, 23:59 UTC
Message-ID: <20200427235935.GA14984@syl.local>
In-Reply-To: <xmqqr1w85vtq.fsf@gitster.c.googlers.com>

On Mon, Apr 27, 2020 at 04:54:09PM -0700, Junio C Hamano wrote:

Show 28 quoted lines

> This step, queued as 3a5c7d70 (commit-graph.c: write non-split
> graphs as read-only, 2020-04-27), starts failing 5318#9 at least for
> me.  Do we need to loosen umask while running this test to something
> not more strict than 022 or something silly like that?
>
> Here is what I'll use as a workaround for today's pushout.
>
> commit f062d1c028bcc839f961e8904c38c476b9deeec3
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Mon Apr 27 16:50:30 2020 -0700
>
>     SQUASH??? force known umask if you are going to check the resulting mode bits
>
> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> index fb0aae61c3..901eb3ecfb 100755
> --- a/t/t5318-commit-graph.sh
> +++ b/t/t5318-commit-graph.sh
> @@ -12,6 +12,10 @@ test_expect_success 'setup full repo' '
>  	test_oid_init
>  '
>
> +test_expect_success POSIXPERM 'tweak umask for modebit tests' '
> +	umask 022
> +'
> +
>  test_expect_success 'verify graph with no graph file' '
>  	cd "$TRASH_DIRECTORY/full" &&
>  	git commit-graph verify

Looks good to me; this is definitely necessary. For what it's worth, it passes for me, but my system may not have as restrictive a umask as others.

I'd be happy to re-send this patch, but alternatively if you want to just squash this in, I'd be just as happy.

Thanks, Taylor