Re: [PATCH] t: handle EOF in test_copy_bytes()
- From
René Scharfe <l.s.r@web.de>
- Date
- Jul 16, 2017, 11:10 UTC
- Message-ID
- <c79eeaec-64e6-db27-d590-ab94a47394d1@web.de>
- In-Reply-To
- <20170716104718.i4nyphyzqh2mzhxt@sigill.intra.peff.net>
Am 16.07.2017 um 12:47 schrieb Jeff King:
Show 9 quoted lines
> On Sun, Jul 16, 2017 at 06:45:32AM -0400, Jeff King wrote: > >> I was playing with SANITIZE=undefined after René's patches to see how >> far we had left to go. I forgot to turn off sha1dc, which causes most >> programs to die due to the unaligned loads. That means git-archive in >> t5000 generates no output, triggering the bug. :) > > And I was pleased to see that after setting OPENSSL_SHA1, the answer to > "how far" is "we are there". Yay.
True with GCC, but not with Clang 3.9. A patch for alignment issues in dir.c is coming up..
René