Re: [PATCH] t: handle EOF in test_copy_bytes()
- From
Jeff King <peff@peff.net>
- Date
- Jul 16, 2017, 11:21 UTC
- Message-ID
- <20170716112100.gktc2ipxbidj6ca6@sigill.intra.peff.net>
- In-Reply-To
- <c79eeaec-64e6-db27-d590-ab94a47394d1@web.de>
On Sun, Jul 16, 2017 at 01:10:50PM +0200, René Scharfe wrote:
Show 5 quoted lines
> > And I was pleased to see that after setting OPENSSL_SHA1, the answer to > > "how far" is "we are there". Yay. > > True with GCC, but not with Clang 3.9. A patch for alignment issues in > dir.c is coming up..
Good to know that there are differences. I used clang for my sanitize runs for the past few years (because of issues I had with gcc's version in the 4.8 era), but just switched a week or two ago back to using gcc.
My impression is that clang is the primary platform for sanitizer development, and so it would probably produce better results. We _could_ force "CC ?= clang" when SANITIZE is set, but that's probably a bit unfriendly to people who only have gcc.
FWIW, I just did an UBSan run with clang-5.0, and it comes up with only the dir.c problem.
-Peff