Re: [PATCH] sparse-checkout: improve OS ls compatibility
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Dec 19, 2019, 16:34 UTC
- Message-ID
- <c68de4d3-c5b6-fc70-a233-9702e9552d94@gmail.com>
- In-Reply-To
- <CAPyFy2AV2NG66LqBJr_Wb1_V5XhKnM+44m0H8FYa_3K4XupLow@mail.gmail.com>
On 12/19/2019 11:15 AM, Ed Maste wrote:
Show 16 quoted lines
> On Thu, 19 Dec 2019 at 08:56, Derrick Stolee <stolee@gmail.com> wrote:
>>
>> On 12/18/2019 9:45 PM, Eric Wong wrote:
>>> This goes on top of your patch:
>> ...
>>> + ( cd "$1" && for i in *; do echo "$i"; done )
>>
>> Could we drop the "cd" and "echo" processes with this line instead?
>>
>> for i in "$1"/*; do printf "$i\n"; done
>
> That would output repo/a, but we could do something like:
> for i in "$1"/*; do echo "${i#$1/}"; done
>
> echo's a builtin on any /bin/sh I'm aware of - do you have a /bin/sh
> with builtin printf but not echo?I guess I am misremembering the benefits of printf over echo. Carry on with your approach.
Thanks, -Stolee