git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sparse-checkout: improve OS ls compatibility

From
Denton Liu <liu.denton@gmail.com>
Date
Dec 19, 2019, 22:27 UTC
Message-ID
<20191219222748.GA63814@generichostname>
In-Reply-To
<20191219214516.69209-1-emaste@FreeBSD.org>
Hi Ed,
On Thu, Dec 19, 2019 at 09:45:16PM +0000, Ed Maste wrote:
Show 12 quoted lines
> On FreeBSD, when executed by root ls enables the '-A' option:
> 
>   -A  Include directory entries whose names begin with a dot (`.')
>       except for . and ...  Automatically set for the super-user unless
>       -I is specified.
> 
> As a result the .git directory appeared in the output when run as root.
> Simulate no-dotfile ls behaviour using a shell glob.
> 
> Signed-off-by: Ed Maste <emaste@FreeBSD.org>
> Helped-by: Eric Wong <e@80x24.org>
> Helped-by: Junio C Hamano <gitster@pobox.com>
Small nit: the Helped-by trailers should come before your sign-off.

Trailers should come in chronological order. Chronologically, they helped you out with your patch and then, after that, you created your v2 based on their review and signed off on it.

Thanks,
Denton
Previous: Ed MasteNext: Ed Maste
Message 13 of 24 in “sparse-checkout: improve OS ls compatibility”
  1. sparse-checkout: improve OS ls compatibilityEd Maste, Dec 19, 2019
  2. Derrick StoleeDec 19, 2019
  3. Ed MasteDec 19, 2019
  4. Derrick StoleeDec 19, 2019
  5. Eric WongDec 19, 2019
  6. Derrick StoleeDec 19, 2019
  7. Ed MasteDec 19, 2019
  8. Derrick StoleeDec 19, 2019
  9. Junio C HamanoDec 19, 2019
  10. Ed MasteDec 19, 2019
  11. Junio C HamanoDec 19, 2019
  12. sparse-checkout: improve OS ls compatibilityEd Maste, Dec 19, 2019
  13. Denton LiuDec 19, 2019
  14. sparse-checkout: improve OS ls compatibilityEd Maste, Dec 20, 2019
  15. Derrick StoleeDec 20, 2019
  16. Junio C HamanoDec 20, 2019
  17. Eric SunshineDec 20, 2019
  18. Ed MasteDec 20, 2019
  19. Junio C HamanoDec 20, 2019
  20. Eric SunshineDec 20, 2019
  21. Ed MasteDec 20, 2019
  22. Junio C HamanoDec 20, 2019
  23. Eric SunshineDec 20, 2019
  24. sparse-checkout: improve OS ls compatibilityEd Maste, Dec 20, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.