Re: [PATCH v4 00/16] Fix git-gc losing objects in multi worktree

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sep 9, 2017, 06:45 UTC
Message-ID: <c627a63e-bb70-9533-f638-e2b9d7ba3d8b@alum.mit.edu>
In-Reply-To: <20170823123704.16518-1-pclouds@gmail.com>

On 08/23/2017 02:36 PM, Nguyễn Thái Ngọc Duy wrote:

Show 10 quoted lines

> "git gc" when used in multiple worktrees ignore some per-worktree
> references: object references in the index, HEAD and reflog. This
> series fixes it by making the revision walker include these from all
> worktrees by default (and the series is basically split in three parts
> in the same order). There's a couple more cleanups in refs.c. Luckily
> it does not conflict with anything in 'pu'.
> 
> Compared to v3 [1], the largest change is supporting multi worktree in
> the reflog iterator. The merge iterator is now used (Micheal was right
> all along).

I read over all of the refs-related changes in this patch series. Aside from the comments that I left, they look good to me. Thanks!

Michael