Re: [PATCH v2] partial-clone: design doc
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Dec 14, 2017, 21:02 UTC
- Message-ID
- <c5d24342-e459-2a5b-6e53-69cddd948140@jeffhostetler.com>
- In-Reply-To
- <xmqq1sjxuq0a.fsf@gitster.mtv.corp.google.com>
On 12/14/2017 1:24 PM, Junio C Hamano wrote:
Show 25 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes: > >> +- On the client these incomplete packfiles are marked as "promisor pacfiles" > > s/pacfiles/packfiles/ > >> + These "promisor packfiles" consist of a "<name>.promisor" file with >> + arbitrary contents (like the "<name>.keep" files), in addition to >> + their "<name>.pack" and "<name>.idx" files. >> + >> + In the future, this ability may be extended to loose objects in case >> + a promisor packfile is accidentally unpacked. > > Hmph. > > Because we cannot assume that such an "accidental" unpacking would > do anything extra to help us tell the loose objects created out of a > promisor pack from other loose objects, you would end up making any > and all loose objects to serve as if they came from a promisor > remote? I am not sure if that makes much sense. > > Do we really need to write this "in the future" down, before we have > thought things through enough to specify the design at a bit more > detailed level? >
good point. i'll move this to the bottom and elaborate on the problem rather than the solution.
Jeff