Re: [PATCH 4/3] sha1_name: use bsearch_pack() in unique_in_pack()

From: René Scharfe <l.s.r@web.de>
Date: Mar 25, 2018, 16:32 UTC
Message-ID: <c56cd048-f0d1-3ed2-6e4e-5063d97071be@web.de>
In-Reply-To: <xmqqvadkf7rd.fsf@gitster-ct.c.googlers.com>

Am 25.03.2018 um 18:19 schrieb Junio C Hamano:

Show 14 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
>> Replace the custom binary search in unique_in_pack() with a call to
>> bsearch_pack().  This reduces code duplication and makes use of the
>> fan-out table of packs.
>>
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>> ---
>> This is basically the same replacement as done by patch 3.  Speed is
>> less of a concern here -- at least I don't know a commonly used
>> command that needs to resolve lots of short hashes.
> 
> Looks correct.  Did you find this by eyeballing, or do you have some
> interesting tool you use?

I was looking for SHA1 binary searches using something like this:

	git grep -e '/ 2' -e hashcmp -W --all-match

René