Re: [RFC PATCH] config.mak.uname: add HAVE_DEV_TTY to cygwin config section

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Sep 6, 2024, 23:53 UTC
Message-ID: <c18fc95a-4dec-4e7b-8ec3-ba9747e9c464@ramsayjones.plus.com>
In-Reply-To: <20240905104331.GD2556395@coredump.intra.peff.net>

On 05/09/2024 11:43, Jeff King wrote:

Show 15 quoted lines

> On Mon, Sep 02, 2024 at 11:15:35PM +0100, Ramsay Jones wrote:
> 
>> Still, I need to do a full test suite run, just to check for any regressions.
>> (Unfortunately, that takes about 6 hours to run, so I can't get to that soon).
> 
> I'm not sure if we cover this at all in the test suite, since it implies
> access to an actual terminal. All of the auth tests rely on the askpass
> interface to simulate the user typing a password.
> 
> We do have test_terminal, which simulates a pty, but I don't think it
> would work for this case. For one thing, I don't know that it counts as
> the controlling terminal, so opening /dev/tty wouldn't find it. And two,
> the stdin handling had race problems that caused us to remove it
> recently. So it's really only good for checking isatty() for
> stdout/stderr.

Heh, yes I suspect you are correct - it's just that I have been tripped up too many times thinking "well, these changes can't possibly affect the test-suite ..." :)

Anyway, I confirmed tonight that there are no regressions noticed by the test-suite. (Which is not to say there aren't any ;) ).

Show 6 quoted lines

> On the plus side, if it works for you in a single manual test then I
> suspect that's enough. The key thing is really "can we get something
> tty-ish that responds to termios", and it sounds like you can.
> 
> Certainly doesn't hurt to test the single-key mode of "add -p", etc,
> though.

Yeah, I still need to check the 'other uses' out. Hmm, I have never used 'add -p' (never felt the need), so I guess I will have to read up on how to use it ...

ATB, Ramsay Jones